Re: [RFC PATCH] gdbstub: attempt to split gdb into 32/64 bit targets [!WORKING PLZ HELP]

[Richard Henderson]

On 3/2/23 13:21, Richard Henderson wrote:
> On 3/2/23 09:25, Alex Bennée wrote:
> > -# These have to built to the target ABI
> > -specific_ss.add(files('syscalls.c'))
> > +# These have to built to the target ABI but are otherwise target
> > +# independent
> > +gdb32_ss = ss.source_set()
> > +gdb64_ss = ss.source_set()
> > +
> > +gdb32_ss.add(files('syscalls.c'))
> > +gdb64_ss.add(files('syscalls.c'))
> > +
> > +gdb32_ss = gdb32_ss.apply(config_host, strict: false)
> > +gdb64_ss = gdb64_ss.apply(config_host, strict: false)
>
> You don't need the source sets.
>
> > +libgdb32 = static_library('gdb32', gdb32_ss.sources(),
> > +                          name_suffix: 'fa',
> > +                          c_args: ['-DTARGET_LONG_BITS=32'])
> > +libgdb64 = static_library('gdb64', gdb64_ss.sources(),
> > +                          name_suffix: 'fa',
> > +                          c_args: ['-DTARGET_LONG_BITS=64'])
> > +
> > +gdb32 = declare_dependency(link_whole: libgdb32)
> > +gdb64 = declare_dependency(link_whole: libgdb64)
>
> It appears to work with "link_with:".
>
> Both comments apply here and to your gdb_user/gdb_softmmu libraries.

Hmm.  It worked for qemu-system-aarch64, but not qemu-system-avr.
I'm at a bit of a loss...


r~