qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL v2 20/24] tests/docker: use direct RUNC call to build containe


From: Akihiro Suda
Subject: Re: [PULL v2 20/24] tests/docker: use direct RUNC call to build containers
Date: Fri, 3 Mar 2023 08:04:34 +0900

> No RUNC is defined in config-host.mak now because it can be docker or
podman.

I feel $(RUNC) isn't the right variable name as it can't be set to "runc".

If $(DOCKER) is not preferable either, $(CONTAINER_ENGINE) might be a better name.
https://github.com/search?l=Makefile&q=%24%28CONTAINER_ENGINE%29&type=Code


2023年3月3日(金) 2:05 Alex Bennée <alex.bennee@linaro.org>:

Akihiro Suda <suda.kyoto@gmail.com> writes:

>> +               $(RUNC) build                           \
>
> There is no `runc build` command.
> Perhaps you meant `$(DOCKER) build`?

No RUNC is defined in config-host.mak now because it can be docker or
podman.

>
> Regards,
> Akihiro Suda


--
Alex Bennée
Virtualisation Tech Lead @ Linaro

reply via email to

[Prev in Thread] Current Thread [Next in Thread]