[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH v1 19/25] hw/xen: Only advertise ring-page-order for xen-bloc
From: |
David Woodhouse |
Subject: |
[RFC PATCH v1 19/25] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it |
Date: |
Thu, 2 Mar 2023 15:34:29 +0000 |
From: David Woodhouse <dwmw@amazon.co.uk>
Whem emulating Xen, multi-page grants are distinctly non-trivial and we
have elected not to support them for the time being. Don't advertise
them to the guest.
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
---
hw/block/xen-block.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 87299615e3..f5a744589d 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -83,7 +83,8 @@ static void xen_block_connect(XenDevice *xendev, Error **errp)
g_free(ring_ref);
return;
}
- } else if (order <= blockdev->props.max_ring_page_order) {
+ } else if (qemu_xen_gnttab_can_map_multi() &&
+ order <= blockdev->props.max_ring_page_order) {
unsigned int i;
nr_ring_ref = 1 << order;
@@ -255,8 +256,12 @@ static void xen_block_realize(XenDevice *xendev, Error
**errp)
}
xen_device_backend_printf(xendev, "feature-flush-cache", "%u", 1);
- xen_device_backend_printf(xendev, "max-ring-page-order", "%u",
- blockdev->props.max_ring_page_order);
+
+ if (qemu_xen_gnttab_can_map_multi()) {
+ xen_device_backend_printf(xendev, "max-ring-page-order", "%u",
+ blockdev->props.max_ring_page_order);
+ }
+
xen_device_backend_printf(xendev, "info", "%u", blockdev->info);
xen_device_frontend_printf(xendev, "virtual-device", "%lu",
--
2.39.0
- Re: [RFC PATCH v1 02/25] hw/xen: Add basic XenStore tree walk and write/read/directory support, (continued)
- [RFC PATCH v1 14/25] hw/xen: Move xenstore_store_pv_console_info to xen_console.c, David Woodhouse, 2023/03/02
- [RFC PATCH v1 03/25] hw/xen: Implement XenStore watches, David Woodhouse, 2023/03/02
- [RFC PATCH v1 09/25] hw/xen: Add evtchn operations to allow redirection to internal emulation, David Woodhouse, 2023/03/02
- [RFC PATCH v1 16/25] hw/xen: Rename xen_common.h to xen_native.h, David Woodhouse, 2023/03/02
- [RFC PATCH v1 19/25] hw/xen: Only advertise ring-page-order for xen-block if gnttab supports it,
David Woodhouse <=
- [RFC PATCH v1 21/25] hw/xen: Add emulated implementation of grant table operations, David Woodhouse, 2023/03/02
- [RFC PATCH v1 10/25] hw/xen: Add gnttab operations to allow redirection to internal emulation, David Woodhouse, 2023/03/02
- [RFC PATCH v1 23/25] hw/xen: Map guest XENSTORE_PFN grant in emulated Xenstore, David Woodhouse, 2023/03/02
- [RFC PATCH v1 25/25] i386/xen: Initialize Xen backends from pc_basic_device_init() for emulation, David Woodhouse, 2023/03/02