Re: [PATCH v2] Fix exec migration on Windows (w32+w64).

[Daniel P . Berrangé]

On Tue, Feb 28, 2023 at 12:35:02PM +0100, Juan Quintela wrote:
> Juan Quintela <quintela@redhat.com> wrote:
> > "John Berberian, Jr" <jeb.study@gmail.com> wrote:
> >> ping. Is there anything I can do to help this get merged?
> >
> > Hi
> >
> > I have to get back from Marc/Daniel before proceed.
> >
> > You did an answer, but they didn't respond.
> >
> > What should we do here?
> >
> > Thanks, Juan.
> 
> Reviewed-by: Juan Quintela <quintela@redhat.com>
> 
> queued.
> 
> Althought I would have preffer to create a
> 
> os_get_cmd_path()
> 
> in both os-win32.c and os-posix.c, so we don't have the #ifdefs at all.

IMHO it is preferable to NOT have it in os-posix/win32 as we don't
want any other areas of QEMU to mistakenly think it is a good idea
to use. This will be relatively short lived once we introduce the
new migration parameters to replace the URI, and can deprecate
the use of shell.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|