qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 00/27] Replace TARGET_TB_PCREL with CF_PCREL


From: Richard Henderson
Subject: Re: [PATCH v3 00/27] Replace TARGET_TB_PCREL with CF_PCREL
Date: Mon, 27 Feb 2023 09:52:55 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 2/27/23 03:51, Anton Johansson wrote:
This patchset entirely replaces the macro TARGET_TB_PCREL with
a field in TranslationBlock.cflags called CF_PCREL, and is a
first step towards removing target-specific assumptions from
non-target/ directories.

The grand goal is to allow for heterogeneous QEMU binaries
consisting of multiple frontends.

RFC: https://lists.nongnu.org/archive/html/qemu-devel/2022-12/msg04518.html

Changes in v2:
   * Setting of CF_PCREL (previously patch 3) was split in two and moved
     up front (to patch 2 and 3);

   * Replacing of TARGET_TB_PCREL (previously patch 2) was split into
     four patches (patches [4,7]), one for each affected submodule;

   * Removal of TARGET_TB_PCREL (previously patch 3) was moved into
     separate patches, one for each submodule (patches [8,10]);

   * Patch 11 was introduced in response to feedback, and removes
     CF_PCREL checks in functions in tb-jmp-cache.h, these functions were
     always called in a context where CF_PCREL was already being checked.
     These tb-jmp-cache.h functions were then removed in favour of manual
     inlining;

   * Patches [12,26] replaces calls to tb_pc() with a member access
     tb->pc, the motivation being that tb_pc() was (almost) always called
     in a context where CF_PCREL was already being checked;

   * Finally patch 27 removes tb_pc() which is no longer used.

Changes in v3:
   * Added reviewed-bys on remaining patches.

Queuing to tcg-next.  Thanks,

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]