[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] tests: Ensure TAP version is printed before other messages
From: |
Richard W.M. Jones |
Subject: |
[PATCH] tests: Ensure TAP version is printed before other messages |
Date: |
Mon, 27 Feb 2023 17:40:19 +0000 |
These two tests were failing with this error:
stderr:
TAP parsing error: version number must be on the first line
[...]
Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming
version 12.
This can be fixed by ensuring we always call g_test_init first in the
body of main.
Thanks: Daniel Berrange, for diagnosing the problem
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
tests/qtest/fuzz-lsi53c895a-test.c | 4 ++--
tests/qtest/rtl8139-test.c | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/qtest/fuzz-lsi53c895a-test.c
b/tests/qtest/fuzz-lsi53c895a-test.c
index a9254b455d..2012bd54b7 100644
--- a/tests/qtest/fuzz-lsi53c895a-test.c
+++ b/tests/qtest/fuzz-lsi53c895a-test.c
@@ -112,12 +112,12 @@ static void test_lsi_do_dma_empty_queue(void)
int main(int argc, char **argv)
{
+ g_test_init(&argc, &argv, NULL);
+
if (!qtest_has_device("lsi53c895a")) {
return 0;
}
- g_test_init(&argc, &argv, NULL);
-
qtest_add_func("fuzz/lsi53c895a/lsi_do_dma_empty_queue",
test_lsi_do_dma_empty_queue);
diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c
index 1beb83805c..4bd240e9ee 100644
--- a/tests/qtest/rtl8139-test.c
+++ b/tests/qtest/rtl8139-test.c
@@ -207,9 +207,10 @@ int main(int argc, char **argv)
verbosity_level = atoi(v_env);
}
- qtest_start("-device rtl8139");
-
g_test_init(&argc, &argv, NULL);
+
+ qtest_start("-device rtl8139");
+
qtest_add_func("/rtl8139/nop", nop);
qtest_add_func("/rtl8139/timer", test_init);
--
2.39.2
- [PATCH] tests: Ensure TAP version is printed before other messages,
Richard W.M. Jones <=
- Re: [PATCH] tests: Ensure TAP version is printed before other messages, Daniel P . Berrangé, 2023/02/27
- Re: [PATCH] tests: Ensure TAP version is printed before other messages, Darren Kenny, 2023/02/27
- Re: [PATCH] tests: Ensure TAP version is printed before other messages, Alexander Bulekov, 2023/02/27
- Re: [PATCH] tests: Ensure TAP version is printed before other messages, Philippe Mathieu-Daudé, 2023/02/27
- Re: [PATCH] tests: Ensure TAP version is printed before other messages, Alex Bennée, 2023/02/28
- Re: [PATCH] tests: Ensure TAP version is printed before other messages, Thomas Huth, 2023/02/28