[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v14 12/60] i386/xen: Implement SCHEDOP_poll and SCHEDOP_yield
From: |
David Woodhouse |
Subject: |
[PATCH v14 12/60] i386/xen: Implement SCHEDOP_poll and SCHEDOP_yield |
Date: |
Mon, 27 Feb 2023 14:28:20 +0000 |
From: David Woodhouse <dwmw@amazon.co.uk>
They both do the same thing and just call sched_yield. This is enough to
stop the Linux guest panicking when running on a host kernel which doesn't
intercept SCHEDOP_poll and lets it reach userspace.
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
---
target/i386/kvm/xen-emu.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/target/i386/kvm/xen-emu.c b/target/i386/kvm/xen-emu.c
index 4ed833656f..ebea27caf6 100644
--- a/target/i386/kvm/xen-emu.c
+++ b/target/i386/kvm/xen-emu.c
@@ -234,6 +234,19 @@ static bool kvm_xen_hcall_sched_op(struct kvm_xen_exit
*exit, X86CPU *cpu,
err = schedop_shutdown(cs, arg);
break;
+ case SCHEDOP_poll:
+ /*
+ * Linux will panic if this doesn't work. Just yield; it's not
+ * worth overthinking it because with event channel handling
+ * in KVM, the kernel will intercept this and it will never
+ * reach QEMU anyway. The semantics of the hypercall explicltly
+ * permit spurious wakeups.
+ */
+ case SCHEDOP_yield:
+ sched_yield();
+ err = 0;
+ break;
+
default:
return false;
}
--
2.39.0
- [PATCH v14 41/60] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_PCI_INTX callback, (continued)
- [PATCH v14 41/60] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_PCI_INTX callback, David Woodhouse, 2023/02/27
- [PATCH v14 55/60] hw/xen: Implement emulated PIRQ hypercall support, David Woodhouse, 2023/02/27
- [PATCH v14 18/60] i386/xen: implement XENMEM_add_to_physmap_batch, David Woodhouse, 2023/02/27
- [PATCH v14 30/60] hw/xen: Implement EVTCHNOP_close, David Woodhouse, 2023/02/27
- [PATCH v14 49/60] i386/xen: handle HVMOP_get_param, David Woodhouse, 2023/02/27
- [PATCH v14 36/60] hw/xen: Implement EVTCHNOP_bind_interdomain, David Woodhouse, 2023/02/27
- [PATCH v14 35/60] hw/xen: Implement EVTCHNOP_alloc_unbound, David Woodhouse, 2023/02/27
- [PATCH v14 15/60] i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode, David Woodhouse, 2023/02/27
- [PATCH v14 45/60] i386/xen: Implement HYPERVISOR_grant_table_op and GNTTABOP_[gs]et_verson, David Woodhouse, 2023/02/27
- [PATCH v14 05/60] i386/kvm: handle Xen HVM cpuid leaves, David Woodhouse, 2023/02/27
- [PATCH v14 12/60] i386/xen: Implement SCHEDOP_poll and SCHEDOP_yield,
David Woodhouse <=