Re: [PATCH v3 0/3] VT82xx PCI IRQ routing fixes

[BALATON Zoltan]

On Mon, 27 Feb 2023, Bernhard Beschow wrote:
> This series makes PCI interrupt routing in the VIA south bridges more compliant
> to the PCI specification. It aims to help bringing audio output support to the
> ppc/pegasos2 machine [1].
>
> v3:
> * Remove superfluous if statement in patch 2 (Phil)

Thanks but to help my work could you please do this in patch 4 in my 
series and send a v4 to that one patch also not reverting my changes just 
changing what the review asked for, so I don't have to manually apply 
changes from this series to mine which is what supposed to be committed as 
it has all needed patches as aked by the PPC maintainer to make it easy to 
follow its status? Also replace the assert with a comment as I've asked. 
If you don't want to do that way I'll fold this in in the next version 
after waiting for some more review comments so I can do a respin with all 
needed chaages but doing it this way is not very helpful of you.

Regards,
BALATON Zoltan

> v2:
> * Remove audio patches which were included for proof of concept
>
> Testing done with via-ac97 audio patches on top:
> * `make check`
> * `qemu-system-ppc -M pegasos2 -rtc base=localtime -device
>  ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -kernel
>  morphos-3.17/boot.img`
>  -> There is a nice sound when the Desktop becomes visible.
> * `qemu-system-ppc -M pegasos2 -bios pegasos2.rom -rtc base=localtime -device
>  ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso`
>  -> There is a nice sound when the Desktop becomes visible.
> * `qemu-system-ppc -M pegasos2 -bios pegasos2.rom -rtc base=localtime -device
>  ati-vga,guest_hwcursor=true,romfile="" -cdrom morphos-3.17.iso -device
>  usb-mouse -device usb-kbd`
>  -> The machine hangs when audio is supposed to play while the mouse is moved.
>     This behavior can also be reproduced in v1.
>
> [1] cover.1677004414.git.balaton@eik.bme.hu/">https://patchew.org/QEMU/cover.1677004414.git.balaton@eik.bme.hu/
>
> Bernhard Beschow (3):
>  hw/ppc/pegasos2: Initialize VT8231 PCI IRQ router
>  hw/isa/vt82c686: Implement PCI IRQ routing
>  hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing
>
> hw/isa/vt82c686.c          | 41 ++++++++++++++++++++++++++++++++++++++
> hw/ppc/pegasos2.c          |  6 ++++++
> hw/usb/vt82c686-uhci-pci.c | 12 -----------
> 3 files changed, 47 insertions(+), 12 deletions(-)
>
> --
> 2.39.2