Re: [PATCH 45/76] target/mips: Fix trans_mult_acc return

[Philippe Mathieu-Daudé]

On 25/2/23 10:13, Richard Henderson wrote:
> Success from trans_* subroutines should be true.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/mips/tcg/vr54xx_translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/mips/tcg/vr54xx_translate.c 
> b/target/mips/tcg/vr54xx_translate.c
> index 3e2c98f2c6..a7d241e4e7 100644
> --- a/target/mips/tcg/vr54xx_translate.c
> +++ b/target/mips/tcg/vr54xx_translate.c
> @@ -53,7 +53,7 @@ static bool trans_mult_acc(DisasContext *ctx, arg_r *a,
>       tcg_temp_free(t0);
>       tcg_temp_free(t1);
>   
> -    return false;
> +    return true;

Oops...

Fixes: 5fa38eedbd ("target/mips: Convert Vr54xx MACC* opcodes to 
decodetree")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Queued to mips-next, thanks!