Re: [PATCH v3 20/30] target/arm: Don't use tcg_temp_local_new_*

[Philippe Mathieu-Daudé]

On 25/2/23 09:59, Richard Henderson wrote:
> Since tcg_temp_new_* is now identical, use those.
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/arm/translate-sve.c | 6 +++---
>   target/arm/translate.c     | 6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c
> index 02150d93e8..718a5bce1b 100644
> --- a/target/arm/translate-sve.c
> +++ b/target/arm/translate-sve.c


> @@ -4342,7 +4342,7 @@ void gen_sve_ldr(DisasContext *s, TCGv_ptr base, int vofs,
>           tcg_temp_free_i64(t0);
>       } else {
>           TCGLabel *loop = gen_new_label();
> -        TCGv_ptr tp, i = tcg_const_local_ptr(0);
> +        TCGv_ptr tp, i = tcg_const_ptr(0);

Can we directly switch to tcg_constant_ptr(NULL)?

>           gen_set_label(loop);
>   
> @@ -4427,7 +4427,7 @@ void gen_sve_str(DisasContext *s, TCGv_ptr base, int vofs,
>           tcg_temp_free_i64(t0);
>       } else {
>           TCGLabel *loop = gen_new_label();
> -        TCGv_ptr tp, i = tcg_const_local_ptr(0);
> +        TCGv_ptr tp, i = tcg_const_ptr(0);

Ditto.