Re: [PULL 00/29] Block layer patches

[Philippe Mathieu-Daudé]

Hi,

On 24/2/23 19:50, Peter Maydell wrote:
> On Thu, 23 Feb 2023 at 18:51, Kevin Wolf <kwolf@redhat.com> wrote:
> > The following changes since commit 79b677d658d3d35e1e776826ac4abb28cdce69b8:
> >
> >    Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into 
> > staging (2023-02-21 11:28:31 +0000)
> >
> > are available in the Git repository at:
> >
> >    https://repo.or.cz/qemu/kevin.git tags/for-upstream
> >
> > for you to fetch changes up to 0f385a2420d2c3f8ae7ed65fbe2712027664059e:
> >
> >    block/rbd: Add support for layered encryption (2023-02-23 19:49:35 +0100)
> >
> > ----------------------------------------------------------------
> > Block layer patches
> >
> > - Lock the graph, part 2 (BlockDriver callbacks)
> > - virtio-scsi: fix SCSIDevice hot unplug with IOThread
> > - rbd: Add support for layered encryption
> >
> > ----------------------------------------------------------------
>
>
> Applied, thanks.

Configuring with --extra-cflags=-ggdb, on

C compiler for the host machine: clang (clang 14.0.0 "Apple clang 
version 14.0.0 (clang-1400.0.29.202)")
C linker for the host machine: clang ld64 820.1
Host machine cpu family: aarch64
Host machine cpu: aarch64
...
    CFLAGS                       : -ggdb -g -O2

I'm getting:

../../block/io.c:182:38: warning: reading variable 'bdrv_aio_preadv' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
                                drv->bdrv_aio_preadv ||
                                     ^
../../block/io.c:997:14: warning: reading variable 'bdrv_aio_preadv' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
    if (drv->bdrv_aio_preadv) {
             ^
../../block/io.c:1003:20: warning: reading variable 'bdrv_aio_preadv' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
        acb = drv->bdrv_aio_preadv(bs, offset, bytes, qiov, flags,
                   ^
../../block/io.c:1076:14: warning: reading variable 'bdrv_aio_pwritev' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
    if (drv->bdrv_aio_pwritev) {
             ^
../../block/io.c:1082:20: warning: reading variable 'bdrv_aio_pwritev' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
        acb = drv->bdrv_aio_pwritev(bs, offset, bytes, qiov, flags,
                   ^
../../block/io.c:2899:25: warning: reading variable 'bdrv_aio_flush' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
    } else if (bs->drv->bdrv_aio_flush) {
                        ^
../../block/io.c:2905:24: warning: reading variable 'bdrv_aio_flush' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
        acb = bs->drv->bdrv_aio_flush(bs, bdrv_co_io_em_complete, &co);
                       ^
../../block/io.c:2991:49: warning: reading variable 'bdrv_aio_pdiscard' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
    if (!bs->drv->bdrv_co_pdiscard && !bs->drv->bdrv_aio_pdiscard) {
                                                ^
../../block/io.c:3058:28: warning: reading variable 'bdrv_aio_pdiscard' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
            acb = bs->drv->bdrv_aio_pdiscard(bs, offset, num,
                           ^
../../block/io.c:3094:24: warning: reading variable 'bdrv_aio_ioctl' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
    if (!drv || (!drv->bdrv_aio_ioctl && !drv->bdrv_co_ioctl)) {
                       ^
../../block/io.c:3102:20: warning: reading variable 'bdrv_aio_ioctl' 
requires holding mutex 'graph_lock' [-Wthread-safety-analysis]
        acb = drv->bdrv_aio_ioctl(bs, req, buf, bdrv_co_io_em_complete, 
&co);
                   ^
11 warnings generated.