[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't
From: |
Igor Mammedov |
Subject: |
[PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable |
Date: |
Fri, 24 Feb 2023 16:38:08 +0100 |
previous commit ("pci: fix 'hotplugglable' property behavior") fixed
pcie root port's 'hotpluggable' property to behave consistently.
So we don't need a BSEL crutch anymore to see of device is not
hotpluggable, drop it from 'generic' PCI slots description handling.
BSEL is still used to decide if hotplug part should be called
but that will be moved out of generic code to hotplug one by
followup patches.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 7b982b6072..6b51b7401d 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -590,7 +590,7 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus
*bus)
call_dev_aml_func(DEVICE(bus->devices[devfn]), dev);
/* add _DSM if device has acpi-index set */
- if (pdev->acpi_index && !bsel &&
+ if (pdev->acpi_index &&
!object_property_get_bool(OBJECT(pdev), "hotpluggable",
&error_abort)) {
aml_append(dev, aml_pci_static_endpoint_dsm(pdev));
--
2.39.1
- [PATCH 13/33] pcihp: move PCI _DSM function 0 prolog into separate function, (continued)
- [PATCH 13/33] pcihp: move PCI _DSM function 0 prolog into separate function, Igor Mammedov, 2023/02/24
- [PATCH 11/33] pci: fix 'hotplugglable' property behavior, Igor Mammedov, 2023/02/24
- [PATCH 19/33] tests: acpi: add device with acpi-index on non-hotpluggble bus, Igor Mammedov, 2023/02/24
- [PATCH 20/33] acpi: pci: support acpi-index for non-hotpluggable devices, Igor Mammedov, 2023/02/24
- [PATCH 22/33] tests: acpi: whitelist DSDT before exposing non zero functions, Igor Mammedov, 2023/02/24
- [PATCH 21/33] tests: acpi: update expected blobs, Igor Mammedov, 2023/02/24
- [PATCH 26/33] tests: acpi: add non zero function device with acpi-index on non-hotpluggble bus, Igor Mammedov, 2023/02/24
- [PATCH 24/33] tests: acpi: update expected blobs, Igor Mammedov, 2023/02/24
- [PATCH 25/33] tests: acpi: whitelist DSDT before adding non-0 function device with acpi-index to testcases, Igor Mammedov, 2023/02/24
- [PATCH 23/33] acpi: pci: describe all functions on populated slots, Igor Mammedov, 2023/02/24
- [PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable,
Igor Mammedov <=
- [PATCH 31/33] acpi: pci: move out ACPI PCI hotplug generator from generic slot generator build_append_pci_bus_devices(), Igor Mammedov, 2023/02/24
- [PATCH 30/33] acpi: pci: move BSEL into build_append_pcihp_slots(), Igor Mammedov, 2023/02/24
- [PATCH 27/33] tests: acpi: update expected blobs, Igor Mammedov, 2023/02/24
- [PATCH 28/33] pci: move acpi-index uniqueness check to generic PCI device code, Igor Mammedov, 2023/02/24
- [PATCH 32/33] pcihp: move fields enabling hotplug into AcpiPciHpState, Igor Mammedov, 2023/02/24
- [PATCH 33/33] pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback, Igor Mammedov, 2023/02/24