[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] qga: Add optional `merge-output` flag to guest-exec QAPI
From: |
Daniel Xu |
Subject: |
Re: [PATCH 0/3] qga: Add optional `merge-output` flag to guest-exec QAPI |
Date: |
Thu, 23 Feb 2023 21:50:19 -0700 |
User-agent: |
Cyrus-JMAP/3.9.0-alpha0-172-g9a2dae1853-fm-20230213.001-g9a2dae18 |
On Thu, Feb 23, 2023, at 7:05 PM, Daniel Xu wrote:
> Currently, the captured output (via `capture-output`) is segregated into
> separate GuestExecStatus fields (`out-data` and `err-data`). This means
> that downstream consumers have no way to reassemble the captured data
> back into the original stream.
>
> This is relevant for chatty and semi-interactive (ie. read only) CLI
> tools. Such tools may deliberately interleave stdout and stderr for
> visual effect. If segregated, the output becomes harder to visually
> understand.
>
> This patchset adds support for merging stderr and stdout output streams
> via a new QAPI flag.
>
> Daniel Xu (3):
> qga: test: Use absolute path to test data
> qga: Add optional `merge-output` flag to guest-exec qapi
> qga: test: Add tests for `merge-output` flag
>
> qga/commands.c | 13 +++-
> qga/qapi-schema.json | 6 +-
> tests/unit/test-qga.c | 135 ++++++++++++++++++++++++++++++++++++------
> 3 files changed, 133 insertions(+), 21 deletions(-)
>
> --
> 2.39.1
Apologies for spamming the list. I thought my mail provider
was swallowing my sends but it looks like the list was a bit
slow.
Thanks,
Daniel