[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 1/5] hw/nvme: move adjustment of data_units{read,written}
|
From: |
Klaus Jensen |
|
Subject: |
Re: [PATCH v3 1/5] hw/nvme: move adjustment of data_units{read,written} |
|
Date: |
Fri, 24 Feb 2023 10:34:16 +0100 |
On Feb 24 09:20, Joel Granados wrote:
> On Mon, Feb 20, 2023 at 12:59:22PM +0100, Jesper Devantier wrote:
> > From: Joel Granados <j.granados@samsung.com>
> >
> > In order to return the units_{read/written} required by the SMART log we
> > need to shift the number of bytes value by BDRV_SECTORS_BITS and multiply
> > by 1000. This is a prep patch that moves this adjustment to where the SMART
> > log is calculated in order to use the stats struct for calculating OCP
> > extended smart log values.
>
> This was originally part of another patchset that looked at adding OCP
> to qemu. Why is it needed for this patch set? Should we change the
> wording of the commit to remove the OCP specific stuff? or should we
> just remove the patch all together?
>
It is useful because the Endurance Group Information log page wants to
report Data Units Read/Written in billions of bytes, not in sectors.
But yes, the commit message should be update since it is no longer
related to OCP.
signature.asc
Description: PGP signature