Re: [PATCH v7 1/4] tcg: add 'size' param to probe_access_flags()

[Daniel Henrique Barboza]

On 2/23/23 21:23, Richard Henderson wrote:
> On 2/23/23 14:19, Richard Henderson wrote:
> > On 2/23/23 13:44, Daniel Henrique Barboza wrote:
> > > +    if (unlikely(flags & TLB_NOTDIRTY)) {
> > > +        notdirty_write(env_cpu(env), addr, 1, full, retaddr);
> >
> > That '1' should be 'size'.  Fixed locally.
>
> Hmph, well, that matches the interface, but it's only used to figure out how 
> many pages to process, so any len that doesn't cross a page boundary (which we 
> have checked) is equal bar the tracepoint.

I didn't touch that '1' because I figured it might not be related with how
'size' was going to be handled and any value > 0 would suffice.


Thanks,


Daniel



> r~