qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/5] dump: Introduce win_dump_available()

From: Thomas Huth
Subject: Re: [PATCH v5 4/5] dump: Introduce win_dump_available()
Date: Fri, 24 Feb 2023 08:51:37 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 
On 24/02/2023 08.38, Philippe Mathieu-Daudé wrote:

Remove a pair of TARGET_X86_64 #ifdef'ry by introducing
the win_dump_available() method. Doing so we can build
win_dump.c on any target, and simplify the meson rule.
Nit: The commit description is a little bit misleading now since you introduce the #ifdef in win_dump.c instead. Maybe rather something like:
To make dump.c less target dependent, move the TARGET_X86_64 #ifdef'ry from dump.c to win_dump.c (and introduce a win_dump_available() method there). By doing so we can build win_dump.c on any target, and simplify the meson rule. 

Anyway, you can keep my Reviewed-by here.

 Thomas
reply via email to
[Prev in Thread] Current Thread [Next in Thread]