qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] accel/tcg: Add 'size' param to probe_access_full


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] accel/tcg: Add 'size' param to probe_access_full
Date: Fri, 24 Feb 2023 07:57:54 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0

On 24/2/23 01:45, Richard Henderson wrote:
Change to match the recent change to probe_access_flags.
All existing callers updated to supply 0, so no change in behaviour.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  include/exec/exec-all.h              | 2 +-
  accel/tcg/cputlb.c                   | 4 ++--
  target/arm/mte_helper.c              | 4 ++--
  target/arm/ptw.c                     | 2 +-
  target/arm/sve_helper.c              | 2 +-
  target/arm/translate-a64.c           | 2 +-
  target/i386/tcg/sysemu/excp_helper.c | 4 ++--
  7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 165b050872..b631832e17 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -475,7 +475,7 @@ int probe_access_flags(CPUArchState *env, target_ulong 
addr, int size,
   * and must be consumed or copied immediately, before any further
   * access or changes to TLB @mmu_idx.
   */
-int probe_access_full(CPUArchState *env, target_ulong addr,
+int probe_access_full(CPUArchState *env, target_ulong addr, int size,
                        MMUAccessType access_type, int mmu_idx,
                        bool nonfault, void **phost,
                        CPUTLBEntryFull **pfull, uintptr_t retaddr);

Why is 'size' signed? (similar in probe_access_flags).

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]