[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/13] tests: be a bit more strict cleaning up fifos
From: |
Alex Bennée |
Subject: |
[PULL 03/13] tests: be a bit more strict cleaning up fifos |
Date: |
Thu, 23 Feb 2023 15:57:10 +0000 |
When we re-factored we dropped the unlink() step which turns out to be
required for rmdir to do its thing. If we had been checking the return
value we would have noticed so lets do that with this fix.
Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230221094558.2864616-5-alex.bennee@linaro.org>
diff --git a/tests/unit/test-io-channel-command.c
b/tests/unit/test-io-channel-command.c
index 04b75ab3b4..c6e66a8c33 100644
--- a/tests/unit/test-io-channel-command.c
+++ b/tests/unit/test-io-channel-command.c
@@ -42,6 +42,7 @@ static void test_io_channel_command_fifo(bool async)
g_auto(GStrv) dstargv = g_strsplit(dstargs, " ", -1);
QIOChannel *src, *dst;
QIOChannelTest *test;
+ int err;
if (mkfifo(fifo, 0600)) {
g_error("mkfifo: %s", strerror(errno));
@@ -61,7 +62,10 @@ static void test_io_channel_command_fifo(bool async)
object_unref(OBJECT(src));
object_unref(OBJECT(dst));
- g_rmdir(tmpdir);
+ err = g_unlink(fifo);
+ g_assert(err == 0);
+ err = g_rmdir(tmpdir);
+ g_assert(err == 0);
}
static void test_io_channel_command_fifo_async(void)
--
2.39.1
- [PULL 00/13] testing updates (gitlab, cirrus, docker, avocado, windows), Alex Bennée, 2023/02/23
- [PULL 05/13] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs, Alex Bennée, 2023/02/23
- [PULL 01/13] tests: don't run socat tests on MacOS as well, Alex Bennée, 2023/02/23
- [PULL 08/13] testing: update ubuntu2004 to ubuntu2204, Alex Bennée, 2023/02/23
- [PULL 03/13] tests: be a bit more strict cleaning up fifos,
Alex Bennée <=
- [PULL 04/13] tests: make fp-test less chatty when running from test suite, Alex Bennée, 2023/02/23
- [PULL 02/13] tests: add socat dependency for tests, Alex Bennée, 2023/02/23
- [PULL 07/13] tests: don't run benchmarks for the tsan build, Alex Bennée, 2023/02/23
- [PULL 06/13] gitlab: extend custom runners with base_job_template, Alex Bennée, 2023/02/23
- [PULL 12/13] tests: ensure we export job results for some cross builds, Alex Bennée, 2023/02/23
- [PULL 09/13] tests: skip the nios2 replay_kernel test, Alex Bennée, 2023/02/23
- [PULL 10/13] tests: add tuxrun baseline test to avocado, Alex Bennée, 2023/02/23
- [PULL 13/13] cirrus.yml: Improve the windows_msys2_task, Alex Bennée, 2023/02/23
- [PULL 11/13] tests/docker: Use binaries for debian-tricore-cross, Alex Bennée, 2023/02/23
- Re: [PULL 00/13] testing updates (gitlab, cirrus, docker, avocado, windows), Peter Maydell, 2023/02/24