Re: [PATCH v2 5/5] gitlab-ci.d: Build with --enable-fdt=system by default

[Daniel P . Berrangé]

On Tue, Feb 07, 2023 at 09:14:47PM +0100, Thomas Huth wrote:
> By using --enable-fdt=system we can make sure that the configure
> script does not try to check out the "dtc" submodule. This should
> help to safe some precious CI minutes in the long run.

If our containers have the system dtc installed, I'm pretty
surprised that configure is choosing to use dtc submodule.
I thought we won't touch the submodule at all if system dtc
was sufficiently new.

IOW, do we have a logic bug in configure making it incorrectly
use dtc submodules ?

> While we're at it, also drop some now-redundant --enable-slirp
> and --enable-capstone statements. These used to have the "=system"
> suffix in the past, too, which has been dropped when the their
> corresponding submodules had been removed. Since these features
> are auto-enabled anyway now (since the containers have the right
> libraries installed), we do not need the explicit --enable-...
> statements anymore.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitlab-ci.d/buildtest-template.yml  | 2 +-
>  .gitlab-ci.d/buildtest.yml           | 9 +++------
>  .gitlab-ci.d/crossbuild-template.yml | 5 +++--
>  .gitlab-ci.d/crossbuilds.yml         | 2 ++
>  .gitlab-ci.d/windows.yml             | 7 +++++--
>  5 files changed, 14 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


since it at least does what it claims, even if it the configure
logic is questionable.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|