|
From: | Markus Armbruster |
Subject: | Re: [PATCH v3 4/4] target/ppc: Restrict 'qapi-commands-machine.h' to system emulation |
Date: | Thu, 23 Feb 2023 14:42:16 +0100 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Philippe Mathieu-Daudé <philmd@linaro.org> writes: > Since commit a0e61807a3 ("qapi: Remove QMP events and commands from > user-mode builds") we don't generate the "qapi-commands-machine.h" > header in a user-emulation-only build. > > Move the QMP functions from cpu_init.c (which is always compiled) to > monitor.c (which is only compiled when system-emulation is selected). > Note ppc_cpu_class_by_name() is used by both file units, so we expose > its prototype in "cpu-qom.h". My comment on PATCH 1 applies. > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Reviewed-by: Richard Henderson <richard.henderson@linaro.org> > Reviewed-by: Cédric Le Goater <clg@kaod.org>
[Prev in Thread] | Current Thread | [Next in Thread] |