qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 5/7] targer/arm: Inform helpers whether a PAC instruction


From: Richard Henderson
Subject: Re: [PATCH v2 5/7] targer/arm: Inform helpers whether a PAC instruction is 'combined'
Date: Wed, 22 Feb 2023 10:56:02 -1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1

On 2/22/23 09:35, Aaron Lindsay wrote:
  static uint64_t pauth_auth(CPUARMState *env, uint64_t ptr, uint64_t modifier,
-                           ARMPACKey *key, bool data, int keynumber)
+                           ARMPACKey *key, bool data, int keynumber,
+                           bool is_combined)

Add 'ra' argument here at the same time, to avoid modifying calls to this function in successive patches.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]