Re: [PATCH v3 09/24] gdbstub: move chunk of softmmu functionality to own file

[Richard Henderson]

On 2/21/23 12:52, Alex Bennée wrote:
> This is mostly code motion but a number of things needed to be done
> for this minimal patch set:
>
>    - move shared structures to internals.h
>    - splitting some functions into user and softmmu versions
>    - fixing a few casting issues to keep softmmu common
>
> More CONFIG_USER_ONLY stuff will be handled in a following patches.
>
> Reviewed-by: Fabiano Rosas<farosas@suse.de>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
>
> ---
> v3
>    - rebase fixes
>    - move extern to internals.h
> ---
>   gdbstub/internals.h  |  43 ++++-
>   gdbstub/gdbstub.c    | 421 +------------------------------------------
>   gdbstub/softmmu.c    | 415 ++++++++++++++++++++++++++++++++++++++++++
>   gdbstub/trace-events |   4 +-
>   4 files changed, 470 insertions(+), 413 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~