[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 6/8] hw/char/cmsdk-apb-uart: Open-code cmsdk_apb_uart_create(
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 6/8] hw/char/cmsdk-apb-uart: Open-code cmsdk_apb_uart_create() |
|
Date: |
Tue, 21 Feb 2023 16:49:56 +0000 |
On Mon, 20 Feb 2023 at 15:34, Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > cmsdk_apb_uart_create() is only used twice in the same
> > file. Open-code it.
>
> Hmm, you could just as easily make cmsdk_apb_uart_create a private
> static function and avoid any copy paste snafus if something needs
> changing.
I think this is fine, the function isn't really gaining
us much.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH 3/8] hw/char/pl011: Open-code pl011_luminary_create(), (continued)
- [PATCH 4/8] hw/char/xilinx_uartlite: Expose XILINX_UARTLITE QOM type, Philippe Mathieu-Daudé, 2023/02/20
- [PATCH 5/8] hw/char/xilinx_uartlite: Open-code xilinx_uartlite_create(), Philippe Mathieu-Daudé, 2023/02/20
- [PATCH 6/8] hw/char/cmsdk-apb-uart: Open-code cmsdk_apb_uart_create(), Philippe Mathieu-Daudé, 2023/02/20
- [PATCH 8/8] hw/intc/armv7m_nvic: Use QOM cast CPU() macro, Philippe Mathieu-Daudé, 2023/02/20
- [PATCH 7/8] hw/timer/cmsdk-apb-timer: Remove unused 'qdev-properties.h' header, Philippe Mathieu-Daudé, 2023/02/20
- Re: [PATCH 0/8] hw/arm: Cleanups around QOM style, Peter Maydell, 2023/02/21