[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v7 3/5] blockdev: qmp_transaction: refactor loop to classic for
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[PATCH v7 3/5] blockdev: qmp_transaction: refactor loop to classic for |
Date: |
Tue, 21 Feb 2023 18:50:49 +0300 |
From: Vladimir Sementsov-Ogievskiy <vladimir.sementsov-ogievskiy@openvz.org>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
blockdev.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 2174ab2694..89c573a094 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2375,7 +2375,7 @@ void qmp_transaction(TransactionActionList *actions,
struct TransactionProperties *properties,
Error **errp)
{
- TransactionActionList *act = actions;
+ TransactionActionList *act;
bool has_properties = !!properties;
JobTxn *block_job_txn = NULL;
Error *local_err = NULL;
@@ -2395,14 +2395,11 @@ void qmp_transaction(TransactionActionList *actions,
bdrv_drain_all();
/* We don't do anything in this loop that commits us to the operations */
- while (NULL != act) {
- TransactionAction *dev_info = NULL;
+ for (act = actions; act; act = act->next) {
+ TransactionAction *dev_info = act->value;
const BlkActionOps *ops;
BlkActionState *state;
- dev_info = act->value;
- act = act->next;
-
assert(dev_info->type < ARRAY_SIZE(actions_map));
ops = &actions_map[dev_info->type];
--
2.34.1
- [PATCH v7 0/5] block: refactor blockdev transactions, Vladimir Sementsov-Ogievskiy, 2023/02/21
- [PATCH v7 1/5] blockdev: refactor transaction to use Transaction API, Vladimir Sementsov-Ogievskiy, 2023/02/21
- [PATCH v7 3/5] blockdev: qmp_transaction: refactor loop to classic for,
Vladimir Sementsov-Ogievskiy <=
- [PATCH v7 2/5] blockdev: transactions: rename some things, Vladimir Sementsov-Ogievskiy, 2023/02/21
- [PATCH v7 4/5] blockdev: transaction: refactor handling transaction properties, Vladimir Sementsov-Ogievskiy, 2023/02/21
- [PATCH v7 5/5] blockdev: qmp_transaction: drop extra generic layer, Vladimir Sementsov-Ogievskiy, 2023/02/21
- Re: [PATCH v7 0/5] block: refactor blockdev transactions, Vladimir Sementsov-Ogievskiy, 2023/02/21