[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/9] simpletrace: Annotate magic constants from QEMU code
From: |
Mads Ynddal |
Subject: |
[PATCH 2/9] simpletrace: Annotate magic constants from QEMU code |
Date: |
Tue, 21 Feb 2023 10:00:57 +0100 |
From: Mads Ynddal <m.ynddal@samsung.com>
It wasn't clear where the constants and structs came from, so I added
comments to help.
Signed-off-by: Mads Ynddal <m.ynddal@samsung.com>
---
scripts/simpletrace.py | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py
index 9211caaec1..7ba805443d 100755
--- a/scripts/simpletrace.py
+++ b/scripts/simpletrace.py
@@ -15,15 +15,15 @@
from tracetool import read_events, Event
from tracetool.backend.simple import is_string
-header_event_id = 0xffffffffffffffff
-header_magic = 0xf2b177cb0aa429b4
-dropped_event_id = 0xfffffffffffffffe
+header_event_id = 0xffffffffffffffff # trace/simple.c::HEADER_EVENT_ID
+header_magic = 0xf2b177cb0aa429b4 # trace/simple.c::HEADER_MAGIC
+dropped_event_id = 0xfffffffffffffffe # trace/simple.c::DROPPED_EVENT_ID
-record_type_mapping = 0
-record_type_event = 1
+record_type_mapping = 0 # trace/simple.c::TRACE_RECORD_TYPE_MAPPING
+record_type_event = 1 # trace/simple.c::TRACE_RECORD_TYPE_EVENT
-log_header_fmt = '=QQQ'
-rec_header_fmt = '=QQII'
+log_header_fmt = '=QQQ' # trace/simple.c::TraceLogHeader
+rec_header_fmt = '=QQII' # trace/simple.c::TraceRecord
def read_header(fobj, hfmt):
'''Read a trace record header'''
--
2.38.1
- [PATCH 0/9] simpletrace: refactor and general improvements, Mads Ynddal, 2023/02/21
- [PATCH 1/9] simpletrace: Improve parsing of sys.argv; fix files never closed., Mads Ynddal, 2023/02/21
- [PATCH 2/9] simpletrace: Annotate magic constants from QEMU code,
Mads Ynddal <=
- [PATCH 3/9] simpletrace: changed naming of edict and idtoname to improve readability, Mads Ynddal, 2023/02/21
- [PATCH 4/9] simpletrace: update code for Python 3.11, Mads Ynddal, 2023/02/21
- [PATCH 5/9] simpletrace: Changed Analyzer class to become context-manager, Mads Ynddal, 2023/02/21
- [PATCH 6/9] simpletrace: Simplify construction of tracing methods, Mads Ynddal, 2023/02/21
- [PATCH 7/9] simpletrace: Improved error handling on struct unpack, Mads Ynddal, 2023/02/21
- [PATCH 8/9] simpletrace: define exception and add handling, Mads Ynddal, 2023/02/21
- [PATCH 9/9] simpletrace: Refactor to separate responsibilities, Mads Ynddal, 2023/02/21