Re: [PATCH 2/8] hw/char/pl011: Un-inline pl011

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/8] hw/char/pl011: Un-inline pl011_create()

From:	Alex Bennée
Subject:	Re: [PATCH 2/8] hw/char/pl011: Un-inline pl011_create()
Date:	Mon, 20 Feb 2023 15:30:39 +0000
User-agent:	mu4e 1.9.21; emacs 29.0.60

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> pl011_create() is only used in DeviceRealize handlers,
> not a hot-path. Inlining is not justified.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 0/8] hw/arm: Cleanups around QOM style, Philippe Mathieu-Daudé, 2023/02/20
- [PATCH 1/8] hw/gpio/max7310: Simplify max7310_realize(), Philippe Mathieu-Daudé, 2023/02/20
  - Re: [PATCH 1/8] hw/gpio/max7310: Simplify max7310_realize(), Richard Henderson, 2023/02/20
- [PATCH 2/8] hw/char/pl011: Un-inline pl011_create(), Philippe Mathieu-Daudé, 2023/02/20
  - Re: [PATCH 2/8] hw/char/pl011: Un-inline pl011_create(), Alex Bennée <=
  - Re: [PATCH 2/8] hw/char/pl011: Un-inline pl011_create(), Richard Henderson, 2023/02/20
- [PATCH 3/8] hw/char/pl011: Open-code pl011_luminary_create(), Philippe Mathieu-Daudé, 2023/02/20
  - Re: [PATCH 3/8] hw/char/pl011: Open-code pl011_luminary_create(), Alex Bennée, 2023/02/20
  - Re: [PATCH 3/8] hw/char/pl011: Open-code pl011_luminary_create(), Richard Henderson, 2023/02/20
- [PATCH 4/8] hw/char/xilinx_uartlite: Expose XILINX_UARTLITE QOM type, Philippe Mathieu-Daudé, 2023/02/20
  - Re: [PATCH 4/8] hw/char/xilinx_uartlite: Expose XILINX_UARTLITE QOM type, Alex Bennée, 2023/02/20
  - Re: [PATCH 4/8] hw/char/xilinx_uartlite: Expose XILINX_UARTLITE QOM type, Richard Henderson, 2023/02/20
- [PATCH 5/8] hw/char/xilinx_uartlite: Open-code xilinx_uartlite_create(), Philippe Mathieu-Daudé, 2023/02/20
  - Re: [PATCH 5/8] hw/char/xilinx_uartlite: Open-code xilinx_uartlite_create(), Alex Bennée, 2023/02/20
  - Re: [PATCH 5/8] hw/char/xilinx_uartlite: Open-code xilinx_uartlite_create(), Richard Henderson, 2023/02/20

Prev by Date: Re: [PATCH 3/4] win32: stop mixing SOCKET and file descriptor space
Next by Date: Re: [PATCH 3/8] hw/char/pl011: Open-code pl011_luminary_create()
Previous by thread: [PATCH 2/8] hw/char/pl011: Un-inline pl011_create()
Next by thread: Re: [PATCH 2/8] hw/char/pl011: Un-inline pl011_create()
Index(es):
- Date
- Thread