[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 0/7] revert RNG seed mess
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH RFC 0/7] revert RNG seed mess |
Date: |
Mon, 20 Feb 2023 10:48:57 +0000 |
User-agent: |
Mutt/2.2.9 (2022-11-12) |
On Fri, Feb 10, 2023 at 11:32:58AM +0000, Daniel P. Berrangé wrote:
> On Wed, Feb 08, 2023 at 04:12:23PM -0500, Michael S. Tsirkin wrote:
> > All attempts to fix up passing RNG seed via setup_data entry failed.
> > Let's just rip out all of it. We'll start over.
> >
> >
> > Warning: all I did was git revert the relevant patches and resolve the
> > (trivial) conflicts. Not even compiled - it's almost midnight here.
> >
> > Jason this is the kind of approach I'd like to see, not yet another
> > pointer math rich patch I need to spend time reviewing. Just get us back
> > to where we started. We can redo "x86: use typedef for SetupData struct"
> > later if we want, it's benign.
>
> This approach looks suitable for applying to the 7.2 tree too,
> which will be good for fixing the regressions in stable.
Since no further alternative has been proposed, can you consider sending
a pull request for this series. This has been broken for too long and
many users & vendors are looking for an official fix to be applied to
master before they backport to 7.2
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH RFC 5/7] Revert "x86: use typedef for SetupData struct", (continued)
- [PATCH RFC 5/7] Revert "x86: use typedef for SetupData struct", Michael S. Tsirkin, 2023/02/08
- [PATCH RFC 7/7] Revert "hw/i386: pass RNG seed via setup_data entry", Michael S. Tsirkin, 2023/02/08
- Re: [PATCH RFC 0/7] revert RNG seed mess, Dov Murik, 2023/02/09
- Re: [PATCH RFC 0/7] revert RNG seed mess, Nathan Chancellor, 2023/02/09
- Re: [PATCH RFC 0/7] revert RNG seed mess, Daniel P . Berrangé, 2023/02/10
- Re: [PATCH RFC 0/7] revert RNG seed mess,
Daniel P . Berrangé <=