[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3] configure: Add 'mkdir build' check
From: |
Dinah Baum |
Subject: |
[PATCH v3] configure: Add 'mkdir build' check |
Date: |
Fri, 17 Feb 2023 15:40:06 -0500 |
QEMU configure script goes into an infinite error printing loop
when in read only directory due to 'build' dir never being created.
Checking if 'mkdir dir' succeeds prevents this error.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/321
Signed-off-by: Dinah Baum <dinahbaum123@gmail.com>
---
Changes since v2:
Updated error message
Reverted changes to 'help' command
configure | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 00415f0b48..784f9d18a5 100755
--- a/configure
+++ b/configure
@@ -31,7 +31,12 @@ then
fi
fi
- mkdir build
+ if ! mkdir build || ! touch $MARKER
+ then
+ echo "ERROR: Could not create ./build directory. Check the permissions
on
+ your source directory, or try doing an out-of-tree build."
+ exit 1
+ fi
touch $MARKER
cat > GNUmakefile <<'EOF'
--
2.30.2
- [PATCH v3] configure: Add 'mkdir build' check,
Dinah Baum <=