[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 0/2] vhost: memslot handling improvements
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v1 0/2] vhost: memslot handling improvements |
Date: |
Thu, 16 Feb 2023 11:04:23 -0500 |
On Thu, Feb 16, 2023 at 12:47:50PM +0100, David Hildenbrand wrote:
> Following up on my previous work to make virtio-mem consume multiple
> memslots dynamically [1] that requires precise accounting between used vs.
> reserved memslots, I realized that vhost makes this extra hard by
> filtering out some memory region sections (so they don't consume a
> memslot) in the vhost-user case, which messes up the whole memslot
> accounting.
>
> This series fixes what I found to be broken and prepares for more work on
> [1]. Further, it cleanes up the merge checks that I consider unnecessary.
>
> [1] https://lkml.kernel.org/r/20211027124531.57561-8-david@redhat.com
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> David Hildenbrand (2):
> vhost: Defer filtering memory sections until building the vhost memory
> structure
> vhost: Remove vhost_backend_can_merge() callback
>
> hw/virtio/vhost-user.c | 14 -----
> hw/virtio/vhost-vdpa.c | 1 -
> hw/virtio/vhost.c | 85 ++++++++++++++++++++-----------
> include/hw/virtio/vhost-backend.h | 4 --
> 4 files changed, 56 insertions(+), 48 deletions(-)
>
> --
> 2.39.1
>
I'm not familiar enough with the memslot code to review this properly,
but overall it looks okay:
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature
[PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback, David Hildenbrand, 2023/02/16
Re: [PATCH v1 0/2] vhost: memslot handling improvements,
Stefan Hajnoczi <=
Re: [PATCH v1 0/2] vhost: memslot handling improvements, Michael S. Tsirkin, 2023/02/17