[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] Adding new machine Yosemitev2 in QEMU
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3] Adding new machine Yosemitev2 in QEMU |
|
Date: |
Thu, 16 Feb 2023 15:27:56 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 16/2/23 14:33, Karthikeyan Pasupathi wrote:
This patch support Yosemitev2 in QEMU environment.
and introduced EEPROM BMC FRU data support "add fbyv2_bmc_fruid data"
along with the machine support.
Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
hw/arm/aspeed.c | 31 +++++++++++++++++++++++++++++++
hw/arm/aspeed_eeprom.c | 23 +++++++++++++++++++++++
hw/arm/aspeed_eeprom.h | 3 +++
3 files changed, 57 insertions(+)
+static void aspeed_machine_yosemitev2_class_init(ObjectClass *oc, void *data)
+{
+ MachineClass *mc = MACHINE_CLASS(oc);
+ AspeedMachineClass *amc = ASPEED_MACHINE_CLASS(oc);
+
+ mc->desc = "Facebook YosemiteV2 BMC (ARM1176)";
+ amc->soc_name = "ast2500-a1";
+ amc->hw_strap1 = AST2500_EVB_HW_STRAP1;
+ amc->hw_strap2 = 0;
+ amc->fmc_model = "n25q256a";
+ amc->spi_model = "mx25l25635e";
+ amc->num_cs = 2;
+ amc->i2c_init = yosemitev2_bmc_i2c_init;
+ mc->default_ram_size = 512 * MiB;
Odd indentation
+ mc->default_cpus = mc->min_cpus = mc->max_cpus =
+ aspeed_soc_num_cpus(amc->soc_name);
Here too. What about:
mc->default_cpus = mc->min_cpus = mc->max_cpus
= aspeed_soc_num_cpus(amc->soc_name);
I suppose Cédric can fix when applying, no need for v4.