Re: [PATCH v5 06/14] Hexagon (target/hexagon) Don't set pkt_has_store_s1 when not needed

[Anton Johansson]

On 1/31/23 23:56, Taylor Simpson wrote:
> The pkt_has_store_s1 field in CPUHexagonState is only needed in generated
> helpers for scalar load instructions.  See check_noshuf and mem_load[1248]
> in op_helper.c.
>
> We add logic in gen_analyze_funcs.py to set need_pkt_has_store_s1 in
> DisasContext when it is needed at runtime.
>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>   target/hexagon/translate.h          | 1 +
>   target/hexagon/attribs_def.h.inc    | 1 +
>   target/hexagon/translate.c          | 6 +++++-
>   target/hexagon/gen_analyze_funcs.py | 5 +++++
>   target/hexagon/hex_common.py        | 1 +
>   5 files changed, 13 insertions(+), 1 deletion(-)
Reviewed-by: Anton Johansson <anjo@rev.ng>