[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/5] spapr/ddw: Remove confuse return value in spapr_phb_get_free
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 2/5] spapr/ddw: Remove confuse return value in spapr_phb_get_free_liobn() |
Date: |
Thu, 16 Feb 2023 13:25:21 +0100 |
The '1' returned value isn't used because
spapr_phb_get_free_liobn_cb() isn't called recursively
(it is only called once in spapr_phb_get_free_liobn()).
The next commit will convert object_child_foreach()
handlers to return a boolean indicating error.
Remove this value to avoid confusion.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/ppc/spapr_rtas_ddw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/spapr_rtas_ddw.c b/hw/ppc/spapr_rtas_ddw.c
index 7ba11382bc..98f1310c6e 100644
--- a/hw/ppc/spapr_rtas_ddw.c
+++ b/hw/ppc/spapr_rtas_ddw.c
@@ -51,7 +51,6 @@ static int spapr_phb_get_free_liobn_cb(Object *child, void
*opaque)
tcet = (SpaprTceTable *) object_dynamic_cast(child, TYPE_SPAPR_TCE_TABLE);
if (tcet && !tcet->nb_table) {
*(uint32_t *)opaque = tcet->liobn;
- return 1;
}
return 0;
}
--
2.38.1
- [PATCH 0/5] bulk: Have object_child_foreach() take Error* and return boolean, Philippe Mathieu-Daudé, 2023/02/16
- [PATCH 1/5] hw/nmi: Have nmi_monitor_handler() return a boolean indicating error, Philippe Mathieu-Daudé, 2023/02/16
- [PATCH 2/5] spapr/ddw: Remove confuse return value in spapr_phb_get_free_liobn(),
Philippe Mathieu-Daudé <=
- [RFC PATCH 4/5] hw/nmi: Simplify nmi_monitor_handle() and do_nmi(), Philippe Mathieu-Daudé, 2023/02/16
- [PATCH 3/5] bulk: Have object_child_foreach() take Error* and return boolean, Philippe Mathieu-Daudé, 2023/02/16
- [RFC PATCH 5/5] hw/ppc/pnv_bmc: Simplify pnv_bmc_find(), Philippe Mathieu-Daudé, 2023/02/16
- Re: [RFC PATCH 5/5] hw/ppc/pnv_bmc: Simplify pnv_bmc_find(), Markus Armbruster, 2023/02/23