[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Adding new machine Yosemitev2 in QEMU
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] Adding new machine Yosemitev2 in QEMU |
|
Date: |
Thu, 16 Feb 2023 12:10:07 +0100 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 |
Hi Pasupathi,
On 16/2/23 11:48, Karthikeyan Pasupathi wrote:
Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
---
hw/arm/aspeed.c | 38 ++++++++++++++++++++++++++++++++++++++
hw/arm/aspeed_eeprom.c | 23 +++++++++++++++++++++++
hw/arm/aspeed_eeprom.h | 3 +++
3 files changed, 64 insertions(+)
+static void yosemitev2_bmc_i2c_init(AspeedMachineState *bmc)
+{
+ AspeedSoCState *soc = &bmc->soc;
+
+ I2CBus *i2c[16];
+
+ for (int i = 0; i < 16; i++) {
+ i2c[i] = aspeed_i2c_get_bus(&soc->i2c, i);
+ }
+
+ at24c_eeprom_init(i2c[4], 0x51, 128 * KiB);
+
+ at24c_eeprom_init_rom(i2c[8], 0x51, 128 * KiB, fbyv2_bmc_fruid,
+ fbyv2_bmc_fruid_len);
This can be simplified as:
at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 4), 0x51, 128 * KiB);
at24c_eeprom_init_rom(aspeed_i2c_get_bus(&soc->i2c, 8), 0x51, 128 * KiB,
fbyv2_bmc_fruid, fbyv2_bmc_fruid_len);
+}