Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

[Daniel P . Berrangé]

On Thu, Feb 16, 2023 at 01:33:47PM +0300, Michael Tokarev wrote:
> 15.02.2023 14:26, Daniel P. Berrangé пишет:
> ..
> > > -       choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', 
> > > 'oss', 'pa', 'sdl', 'sndio'],
> > > +       choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', 
> > > 'oss', 'pa', 'pw', 'sdl', 'sndio'],
> > 
> > I appreciate you probably just followed the example of pulseaudio, 
> > abbreviated
> > to 'pa', but I'm not a fan of the existing usage there. So lets be more 
> > verbose
> > and say 'pipewire' so users are clear on what this is.
> 
> I'd vote for "pw" here, it is a quite well-known acronym. It is not because 
> "pa"
> is used in qemu, it is because "pa" and now "pw" is used everywhere in context
> of linux sound.

I don't see 'pw' as well known. The package is 'pipewire', the
processes are 'pipewire', the config files are 'pipewire'. The
'pw' abbreviation is too short to be meaningful unless you are
already familiar with pipewire.

> But if there's no need to type it manually every time, it can
> be "pipewire" too.

"pipewire" is not exactly a long word to begin with, and saving
a couple of letters to abbreviate it isn't going to make a
difference in the context of QEMU's command line.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|