Re: [PATCH 20/20] hw/ide/piix: Refactor pci_piix_init_ports as pci_piix_init_bus per bus

[Richard Henderson]

On 2/15/23 01:27, Philippe Mathieu-Daudé wrote:
> @@ -165,8 +162,10 @@ static void pci_piix_ide_realize(PCIDevice *dev, Error 
> **errp)
>   
>       vmstate_register(VMSTATE_IF(dev), 0, &vmstate_ide_pci, d);
>   
> -    if (!pci_piix_init_ports(d, errp)) {
> -        return;
> +    for (unsigned i = 0; i < 2; i++) {
> +        if (!pci_piix_init_bus(d, i, errp)) {
> +            return;
> +        }

Oh, I see.  You can disregard my comment vs patch 19.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~