Re: [PULL 13/25] hcd-ohci: Fix inconsistency when resetting ohci root hubs

[Laurent Vivier]

On 2/15/23 14:45, Qiang Liu wrote:
> Hi,
>
>         This commit breaks boot-serial-test on ppc64-softmmu.
>
>            $ ./configure --enable-tcg-interpreter
>         '--target-list=aarch64-softmmu alpha-softmmu arm-softmmu hppa-softmmu
>         m68k-softmmu microblaze-softmmu ppc64-softmmu s390x-softmmu
>         x86_64-softmmu'
>            $ make && cd build && QTEST_QEMU_BINARY=./qemu-system-ppc64
>         ./tests/qtest/boot-serial-test; cd -
>
>         (Yes, the full --target-list is needed because boot-serial-test isn't
>         built when only ppc64-softmmu is selected.)

I think we need something like this :

diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
index e97616d327c0..8203f6a71ad0 100644
--- a/tests/qtest/meson.build
+++ b/tests/qtest/meson.build
@@ -149,8 +149,8 @@ qtests_ppc = \
   qtests_filter + \
   (config_all_devices.has_key('CONFIG_ISA_TESTDEV') ? ['endianness-test'] : []) + 
    \
   (config_all_devices.has_key('CONFIG_M48T59') ? ['m48t59-test'] : []) + 
    \
-  (config_all_devices.has_key('CONFIG_TCG') ? ['prom-env-test'] : []) + 
   \
-  (config_all_devices.has_key('CONFIG_TCG') ? ['boot-serial-test'] : []) + 
   \
+  (config_host.has_key('CONFIG_TCG') ? ['prom-env-test'] : []) +               
       \
+  (config_host.has_key('CONFIG_TCG') ? ['boot-serial-test'] : []) +            
       \
   ['boot-order-test']

 qtests_ppc64 = \

Thanks,
Laurent