Re: [PATCH 02/18] vfio/common: Fix error reporting in vfio_get_dirty_bitmap()

[Cédric Le Goater]

On 1/26/23 19:49, Avihai Horon wrote:
> Return -errno instead of -1 if VFIO_IOMMU_DIRTY_PAGES ioctl fails in
> vfio_get_dirty_bitmap().
>
> Signed-off-by: Avihai Horon <avihaih@nvidia.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/vfio/common.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> index 93b18c5e3d..d892609cf1 100644
> --- a/hw/vfio/common.c
> +++ b/hw/vfio/common.c
> @@ -1288,6 +1288,7 @@ static int vfio_get_dirty_bitmap(VFIOContainer 
> *container, uint64_t iova,
>   
>       ret = ioctl(container->fd, VFIO_IOMMU_DIRTY_PAGES, dbitmap);
>       if (ret) {
> +        ret = -errno;
>           error_report("Failed to get dirty bitmap for iova: 0x%"PRIx64
>                   " size: 0x%"PRIx64" err: %d", (uint64_t)range->iova,
>                   (uint64_t)range->size, errno);