[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/8] aspeed: I2C fixes, -drive removal (first step)
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 0/8] aspeed: I2C fixes, -drive removal (first step) |
Date: |
Wed, 15 Feb 2023 07:38:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Cédric Le Goater <clg@kaod.org> writes:
> Hello,
>
> This series starts with a first set of patches fixing I2C slave mode
> in the Aspeed I2C controller, a test device and its associated test in
> avocado.
>
> Follow some cleanups which allow the use of block devices instead of
> drives. So that, instead of specifying :
>
> -drive file=./flash-ast2600-evb,format=raw,if=mtd
> -drive file=./ast2600-evb.pnor,format=raw,if=mtd
> ...
>
> and guessing from the order which bus the device is attached to, we
> can use :
>
> -blockdev node-name=fmc0,driver=file,filename=./bmc.img
> -device mx66u51235f,bus=ssi.0,drive=fmc0
> -blockdev node-name=fmc1,driver=file,filename=./bmc-alt.img
> -device mx66u51235f,bus=ssi.0,drive=fmc1
> -blockdev node-name=pnor,driver=file,filename=./pnor
> -device mx66l1g45g,bus=ssi.1,drive=pnor
> ...
>
> It is not perfect, the CS index still depends on the order, but it is
> now possible to run a machine without -drive ...,if=mtd.
Lovely!
Does this cover all uses of IF_MTD, or only some?
> This lacks the final patch enabling the '-nodefaults' option by not
> creating the default devices if specified on the command line. It
> needs some more evaluation of the possible undesired effects.
Are you thinking of something similar to the default CD-ROM, i.e. use
default_list to have -device suppress a certain kind of default devices,
and also have -nodefaults suppress them all?
- Re: [PATCH 3/8] hw/misc: add a toy i2c echo device, (continued)
[PATCH 4/8] tests/avocado/machine_aspeed.py: Add I2C slave tests, Cédric Le Goater, 2023/02/14
[PATCH 5/8] aspeed/smc: Replace SysBus IRQs with GPIO lines, Cédric Le Goater, 2023/02/14
[PATCH 6/8] aspeed/smc: Wire CS lines at reset, Cédric Le Goater, 2023/02/14
[PATCH 8/8] aspeed: Add a boot_rom overlap region in the SoC spi_boot container, Cédric Le Goater, 2023/02/14
[PATCH 7/8] aspeed: Introduce a spi_boot region under the SoC, Cédric Le Goater, 2023/02/14
Re: [PATCH 0/8] aspeed: I2C fixes, -drive removal (first step),
Markus Armbruster <=
Re: [PATCH 0/8] aspeed: I2C fixes, -drive removal (first step), Philippe Mathieu-Daudé, 2023/02/15