Re: [PATCH] target/s390x/arch_dump: Fix memory corruption in s390x_write_elf64_notes()

[Thomas Huth]

On 15/02/2023 06.20, Thomas Huth wrote:
> On 14/02/2023 15.58, Philippe Mathieu-Daudé wrote:
> > On 14/2/23 15:10, Thomas Huth wrote:
> > > "note_size" can be smaller than sizeof(note), so unconditionally calling
> > > memset(notep, 0, sizeof(note)) could cause a memory corruption here in
> > > case notep has been allocated dynamically, thus let's use note_size as
> > > length argument for memset() instead.
> >
> > Correct.
> >
> > I wonder why use one notep* pointing to a stack allocated or a heap
> > allocated buffer. This isn't hot path, one heap use could simplify
> > this code complexity IMO.
>
> You've got a point. I'll give it a try and send a v2.

Actually, it looked better as a separate, independent patch, so I sent it as 
"Simplify memory allocation in s390x_write_elf64_notes()" (based on this one 
here).

 Thomas