Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

[Vladimir Sementsov-Ogievskiy]

On 02.02.23 21:15, Andrey Zhadchenko via wrote:
> The last return statement should return true, as we already evaluated that
> start == next_dirty
>
> Also, fix hbitmap_status() description in header
>
> Cc: qemu-stable@nongnu.org
> Fixes: a6426475a75 ("block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()")

Ohh :/

> Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>

> ---
>   include/qemu/hbitmap.h | 2 +-
>   util/hbitmap.c         | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qemu/hbitmap.h b/include/qemu/hbitmap.h
> index af4e4ab746..8136e33674 100644
> --- a/include/qemu/hbitmap.h
> +++ b/include/qemu/hbitmap.h
> @@ -330,7 +330,7 @@ bool hbitmap_next_dirty_area(const HBitmap *hb, int64_t 
> start, int64_t end,
>                                int64_t *dirty_start, int64_t *dirty_count);
>   
>   /*
> - * bdrv_dirty_bitmap_status:
> + * hbitmap_status:
>    * @hb: The HBitmap to operate on
>    * @start: The bit to start from
>    * @count: Number of bits to proceed
> diff --git a/util/hbitmap.c b/util/hbitmap.c
> index 297db35fb1..6d6e1b595d 100644
> --- a/util/hbitmap.c
> +++ b/util/hbitmap.c
> @@ -331,7 +331,7 @@ bool hbitmap_status(const HBitmap *hb, int64_t start, 
> int64_t count,
>   
>       assert(next_zero > start);
>       *pnum = next_zero - start;
> -    return false;
> +    return true;
>   }
>   
>   bool hbitmap_empty(const HBitmap *hb)

--
Best regards,
Vladimir