[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/4] cpus: Make {start,end}_exclusive() recursive
From: |
Alex Bennée |
Subject: |
Re: [PATCH v2 2/4] cpus: Make {start,end}_exclusive() recursive |
Date: |
Tue, 14 Feb 2023 09:26:46 +0000 |
User-agent: |
mu4e 1.9.20; emacs 29.0.60 |
Ilya Leoshkevich <iii@linux.ibm.com> writes:
> Currently dying to one of the core_dump_signal()s deadlocks, because
> dump_core_and_abort() calls start_exclusive() two times: first via
> stop_all_tasks(), and then via preexit_cleanup() ->
> qemu_plugin_user_exit().
>
> There are a number of ways to solve this: resume after dumping core;
> check cpu_in_exclusive_context() in qemu_plugin_user_exit(); or make
> {start,end}_exclusive() recursive. Pick the last option, since it's
> the most straightforward one.
>
> Fixes: da91c1920242 ("linux-user: Clean up when exiting due to a signal")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro