Re: [PATCH v4 15/16] qapi: add HOTPLUG_STATE event

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 13/2/23 15:01, Vladimir Sementsov-Ogievskiy wrote:
>> For PCIe and SHPC hotplug it's important to track led indicators,
>> especially the power led. Add an event that helps.
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
>> ---
>>   qapi/qdev.json                  | 175 ++++++++++++++++++++++++++++++++
>>   include/hw/hotplug.h            |  12 +++
>>   include/hw/pci/pci.h            |   3 +
>>   include/hw/pci/pci_bridge.h     |   2 +
>>   include/hw/pci/pcie.h           |   2 +
>>   include/hw/pci/shpc.h           |   2 +
>>   include/monitor/qdev.h          |   5 +
>>   hw/core/hotplug.c               |  13 +++
>>   hw/pci-bridge/pci_bridge_dev.c  |  14 +++
>>   hw/pci-bridge/pcie_pci_bridge.c |   1 +
>>   hw/pci/pcie.c                   |  79 ++++++++++++++
>>   hw/pci/pcie_port.c              |   1 +
>>   hw/pci/shpc.c                   | 102 ++++++++++++++++++-
>>   softmmu/qdev-monitor.c          |  39 +++++++
>>   14 files changed, 445 insertions(+), 5 deletions(-)
>
> -ETOOBIG

Can't see how this could be split sensibly: it's a single query/event
pair.  If you can, let us know.