[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI ta
|
From: |
Andrew Jones |
|
Subject: |
Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables |
|
Date: |
Tue, 14 Feb 2023 07:56:12 +0100 |
On Tue, Feb 14, 2023 at 09:13:28AM +0530, Sunil V L wrote:
> On Mon, Feb 13, 2023 at 03:48:04PM -0300, Daniel Henrique Barboza wrote:
> > Sunil,
> >
> > This patch is a bit confusing to me. You're using functions that doesn't
> > exist
> > in the code base yet (build_madt and build_rhct) because they are introduced
> > in later patches. This also means that this patch is not being compiled
> > tested,
> > because otherwise it would throw a compile error. And the build of the file
> > only
> > happens after patch 8.
> >
> My intention was to add the caller also in the same patch where the
> function is added. I think I missed it when I split. Thanks!
>
Before posting a series I try to remember to do the following check
$ ./configure ...
$ git rebase -i -x 'make -j' $BASE_COMMIT_FOR_SERIES
Thanks,
drew
- [PATCH V2 01/10] hw/riscv/virt: Add OEM_ID and OEM_TABLE_ID fields, (continued)
- [PATCH V2 01/10] hw/riscv/virt: Add OEM_ID and OEM_TABLE_ID fields, Sunil V L, 2023/02/13
- [PATCH V2 02/10] hw/riscv/virt: Add a switch to enable/disable ACPI, Sunil V L, 2023/02/13
- [PATCH V2 03/10] hw/riscv/virt: Add memmap pointer to RiscVVirtState, Sunil V L, 2023/02/13
- [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Sunil V L, 2023/02/13
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Daniel Henrique Barboza, 2023/02/13
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Sunil V L, 2023/02/13
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Bin Meng, 2023/02/13
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables,
Andrew Jones <=
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Daniel Henrique Barboza, 2023/02/14
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Sunil V L, 2023/02/15
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Palmer Dabbelt, 2023/02/16
- Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Sunil V L, 2023/02/16
Re: [PATCH V2 04/10] hw/riscv/virt: virt-acpi-build.c: Add basic ACPI tables, Andrew Jones, 2023/02/15
[PATCH V2 05/10] hw/riscv/virt: virt-acpi-build.c: Add RINTC in MADT, Sunil V L, 2023/02/13
[PATCH V2 06/10] hw/riscv/virt: virt-acpi-build.c: Add RHCT Table, Sunil V L, 2023/02/13
[PATCH V2 07/10] hw/riscv: meson.build: Build virt-acpi-build.c, Sunil V L, 2023/02/13