Re: [PATCH 1/2] log: Add separate debug option for logging invalid memory accesses

[Peter Xu]

On Mon, Feb 13, 2023 at 12:41:29PM +0100, Thomas Huth wrote:
> On 07/02/2023 17.33, BALATON Zoltan wrote:
> > On Tue, 31 Jan 2023, BALATON Zoltan wrote:
> > > On Thu, 19 Jan 2023, BALATON Zoltan wrote:
> > > > Currently -d guest_errors enables logging of different invalid actions
> > > > by the guest such as misusing hardware, accessing missing features or
> > > > invalid memory areas. The memory access logging can be quite verbose
> > > > which obscures the other messages enabled by this debug switch so
> > > > separate it by adding a new -d memaccess option to make it possible to
> > > > control it independently of other guest error logs.
> > > > 
> > > > Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> > > 
> > > Ping? Could somebody review and pick it up please?
> > 
> > Ping?
> 
> Patch makes sense to me and looks fine, so:
> 
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> 
> ... I think this should go via one of the "Memory API" maintainers branches?
> Paolo? Peter? David?

Paolo normally does the pull, I assume that'll still be the case.  The
patch looks good to me if Phil's comment will be addressed on merging with
the old mask, which makes sense to me:

Acked-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu