[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/9] hw/pci: Replace dev->parent_bus by qdev_get_parent_bu
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v2 5/9] hw/pci: Replace dev->parent_bus by qdev_get_parent_bus(dev) |
Date: |
Mon, 13 Feb 2023 05:52:37 -0500 |
On Mon, Feb 13, 2023 at 08:04:19AM +0100, Philippe Mathieu-Daudé wrote:
> DeviceState::parent_bus is an internal field and should be
> accessed by the qdev_get_parent_bus() helper.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/pci-bridge/pci_expander_bridge.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-bridge/pci_expander_bridge.c
> b/hw/pci-bridge/pci_expander_bridge.c
> index e752a21292..8c0649c071 100644
> --- a/hw/pci-bridge/pci_expander_bridge.c
> +++ b/hw/pci-bridge/pci_expander_bridge.c
> @@ -151,7 +151,7 @@ static char *pxb_host_ofw_unit_address(const SysBusDevice
> *dev)
> assert(position >= 0);
>
> pxb_dev_base = DEVICE(pxb_dev);
> - main_host = PCI_HOST_BRIDGE(pxb_dev_base->parent_bus->parent);
> + main_host = PCI_HOST_BRIDGE(qdev_get_parent_bus(pxb_dev_base)->parent);
> main_host_sbd = SYS_BUS_DEVICE(main_host);
>
> if (main_host_sbd->num_mmio > 0) {
> --
> 2.38.1
- [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus(), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 1/9] hw/qdev: Constify DeviceState* argument of qdev_get_parent_bus(), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 2/9] hw/audio: Replace dev->parent_bus by qdev_get_parent_bus(dev), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 3/9] hw/block: Replace dev->parent_bus by qdev_get_parent_bus(dev), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 4/9] hw/net: Replace dev->parent_bus by qdev_get_parent_bus(dev), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 5/9] hw/pci: Replace dev->parent_bus by qdev_get_parent_bus(dev), Philippe Mathieu-Daudé, 2023/02/13
- Re: [PATCH v2 5/9] hw/pci: Replace dev->parent_bus by qdev_get_parent_bus(dev),
Michael S. Tsirkin <=
- [PATCH v2 6/9] hw/ppc: Replace dev->parent_bus by qdev_get_parent_bus(dev), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 7/9] hw/usb: Replace dev->parent_bus by qdev_get_parent_bus(dev), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 8/9] hw: Use qdev_get_parent_bus() in qdev_get_own_fw_dev_path_from_handler(), Philippe Mathieu-Daudé, 2023/02/13
- [PATCH v2 9/9] qdev-monitor: Use qdev_get_parent_bus() in bus_print_dev(), Philippe Mathieu-Daudé, 2023/02/13
- Re: [PATCH v2 0/9] hw/qdev: Housekeeping around qdev_get_parent_bus(), Michael S. Tsirkin, 2023/02/13