|
From: | Shivam Kumar |
Subject: | Re: [RFC PATCH 1/1] Dirty quota-based throttling of vcpus |
Date: | Mon, 13 Feb 2023 14:47:54 +0530 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 |
On 22/11/22 9:30 am, Shivam Kumar wrote:
On 21/11/22 5:05 pm, Philippe Mathieu-Daudé wrote:Hi, On 20/11/22 23:54, Shivam Kumar wrote:+ +void dirty_quota_migration_start(void) +{ + if (!kvm_state->dirty_quota_supported) {You are accessing an accelerator-specific variable in an accelerator-agnostic file, this doesn't sound correct.You might introduce some hooks in AccelClass and implement them in accel/kvm/. See for example gdbstub_supported_sstep_flags() and kvm_gdbstub_sstep_flags().Ack. Thanks, Shivam
Hi Philippe,I had received a suggestion on the kernel-side patchset to make dirty quota a more generic feature and not limit its use to live migration. Incorporating this ask might lead to a significant change in the dirty quota interface. So, I haven't been able to post the next version of the QEMU patchset. I intend to post it once the new proposition looks good to the KVM reviewers.
Thanks, Shivam
[Prev in Thread] | Current Thread | [Next in Thread] |