Re: [PATCH v2 09/13] vdpa net: block migration if the device has CVQ

[Si-Wei Liu]

On 2/8/2023 1:42 AM, Eugenio Pérez wrote:
> Devices with CVQ needs to migrate state beyond vq state.  Leaving this
> to future series.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
>   net/vhost-vdpa.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
> index bca13f97fd..309861e56c 100644
> --- a/net/vhost-vdpa.c
> +++ b/net/vhost-vdpa.c
> @@ -955,11 +955,17 @@ int net_init_vhost_vdpa(const Netdev *netdev, const char 
> *name,
>       }
>   
>       if (has_cvq) {
> +        VhostVDPAState *s;
> +
>           nc = net_vhost_vdpa_init(peer, TYPE_VHOST_VDPA, name,
>                                    vdpa_device_fd, i, 1, false,
>                                    opts->x_svq, iova_range);
>           if (!nc)
>               goto err;
> +
> +        s = DO_UPCAST(VhostVDPAState, nc, nc);
> +        error_setg(&s->vhost_vdpa.dev->migration_blocker,
> +                   "net vdpa cannot migrate with MQ feature");
Not sure how this can work: migration_blocker is only checked and gets 
added from vhost_dev_init(), which is already done through 
net_vhost_vdpa_init() above. Same question applies to the next patch of 
this series.

Thanks,
-Siwei

>       }
>   
>       return 0;