qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/9] 2023 Q1 bsd-user upstreaming: bugfixes and sysctl


From: Warner Losh
Subject: Re: [PATCH 0/9] 2023 Q1 bsd-user upstreaming: bugfixes and sysctl
Date: Sat, 11 Feb 2023 15:20:39 -0700



On Sat, Feb 11, 2023 at 12:30 PM Richard Henderson <richard.henderson@linaro.org> wrote:
On 2/10/23 13:18, Warner Losh wrote:
> There's
> several static functions that aren't used until the end of the patch
> series... Not sure the best way to suppress the build warnings there (but since
> they are just warnings...).

Are they just warnings?  --enable-werror is default...

Anyway, I've used

static type G_GNUC_UNUSED function(args...)

in the past to ensure bisection, removing the UNUSED marker when they become used.

I like that suggestion, and it's easy to implement. Thanks for this and the reviews so far. I've
updated things with your comments, but will give it another day or two before I send v2 for
others to comment.

Warner

reply via email to

[Prev in Thread] Current Thread [Next in Thread]