Re: [PATCH 11/11] hw/isa: Factor isa_bus_get_irq() out of isa_get_irq()

[Richard Henderson]

On 2/10/23 06:37, Philippe Mathieu-Daudé wrote:
> isa_get_irq() was added in commit 3a38d437ca
> ("Add isa_reserve_irq()" Fri Aug 14 11:36:15 2009) as:
>
>      a temporary interface to be used to allocate ISA IRQs for
>      devices which have not yet been converted to qdev, and for
>      special cases which are not suited for qdev conversions,
>      such as the 'ferr'.
>
> We still use it 14 years later, using the global 'isabus'
> singleton. In order to get rid of such*temporary*  interface,
> extract isa_bus_get_irq() which can take any ISABus* object.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   hw/isa/isa-bus.c     | 14 ++++++++++----
>   include/hw/isa/isa.h |  8 ++++++++
>   2 files changed, 18 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~