qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 4/7] configure: Add nice hint to Python failure message


From: John Snow
Subject: Re: [PATCH v2 4/7] configure: Add nice hint to Python failure message
Date: Fri, 10 Feb 2023 14:19:50 -0500



On Fri, Feb 10, 2023, 2:45 AM Thomas Huth <thuth@redhat.com> wrote:
On 10/02/2023 01.31, John Snow wrote:
> If we begin requiring Python 3.7+, a few platforms are going to need to
> install an additional package.
>
> This is at least mildly annoying to the user (and I hate negative
> attention), so solve the user's problem for them before they get a
> chance to become irritated while searching on Google for how to install
> newer Python packages.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   configure | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ea8c973d13b..bf512273f44 100755
> --- a/configure
> +++ b/configure
> @@ -1058,7 +1058,10 @@ fi
>   
>   if ! check_py_version "$python"; then
>     error_exit "Cannot use '$python', Python >= 3.6 is required." \
> -      "Use --python=/path/to/python to specify a supported Python."
> +             "Use --python=/path/to/python to specify a supported Python." \
> +             "Maybe try:" \
> +             "  openSUSE Leap 15.3+: zypper install python39" \
> +             "  CentOS 8: dnf install python38"

IMHO the "Python > 3.6" is already pretty clear, and the hints that you
provide here will expire pretty fast (unless you bump them regularly), so
I'd rather drop this patch. Just my 0.02 €.

  Thomas

I figured that when they expired that they also just wouldn't... get printed anymore. Just trying my best to minimize disruption as a courtesy, and as a demonstration of how gentle the deprecation could be.

I get it though, it *will* rot ... It's the kind of thing that I'd want to have in for maybe a release or two before just removing it, once everyone has a chance to catch on and learn the simple remedy.

(I don't want anyone with 3.6 on their system to be unaware of how to mitigate this issue, and quickly.)

I could replace it with a more generic hint, too; like "Try looking for python3y or python3.y packages in your distro's software repository" that would rot at a slower pace.

--js

reply via email to

[Prev in Thread] Current Thread [Next in Thread]